feat(rules): add no-jasmine-globals

[SimenB]

In preparation for jest-circus, warning users about Jasmine usage would be great.

Will probably add to recommended in next major (whenever eslint 5 comes out)

/cc @captbaritone

[aaronabramov]

oh. this is so awesome!

[mattphillips]

Looks like coverage has dropped slightly and is breaking CI. Maybe we should add coveralls to this project?

[SimenB]

Made jasmine.DEFAULT_TIMEOUT and known asymmetric matchers autofixable. not sure we can do any other ones

[captbaritone]

LGTM. 👏

[mattphillips]

@SimenB can we add a link to the docs for the recommended approach for the patterns we cannot auto fix?

Edit: or put an example in the error message?

[SimenB]

@mattphillips good idea! Feel free to push some examples to the docs 🙂

[thymikee]

Looks good. Wonder if we should use stricter language, something stronger than "Avoid using"?

[SimenB]

Changed "avoid using" to "illegal usage of"

[thymikee]

Like it 👍

[thymikee]

when green :)

[SimenB]

@mattphillips PR welcome with more concrete examples for the docs 🙂

[mattphillips]

👍

[SimenB]

🎉 This PR is included in version 21.16.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[captbaritone]

@aaronabramov We should turn this on for WWW once you are done.

[captbaritone]

Should this get added to the eslint-plugin-jest readme? If so, I can open a PR.

[thymikee]

Of course! Maybe we can even make it recommended?

[captbaritone]

I'll open a PR.

[captbaritone]

I'll wait on making it recommended since @SimenB said:

Will probably add to recommended in next major (whenever eslint 5 comes out)

[SimenB]

Found a bug btw, when applying it to the jest code base. Pushed fix: 885ce17

[SimenB]

🎉 This PR is included in version 21.16.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[SimenB]

Interesting that the bot picked up I referenced the commit in this PR, so posted a comment. Probably a bug :P

[SimenB]

For posterity, these are the errors reported on the Jest code base with this rule active:

/Users/simen/Development/jest/packages/jest-jasmine2/src/index.js
44:15  error  Illegal usage of jasmine global  jest/no-jasmine-globals

/Users/simen/Development/jest/packages/jest-jasmine2/src/jasmine_async.js
136:15  error  Illegal usage of jasmine global  jest/no-jasmine-globals

/Users/simen/Development/jest/packages/jest-jasmine2/src/jest_expect.js
36:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals
37:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals
38:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals
39:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals
40:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals
42:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals

/Users/simen/Development/jest/testSetupFile.js
16:3  error  Illegal usage of jasmine global  jest/no-jasmine-globals