Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add expect-expect rule in list #137

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Add expect-expect rule in list #137

merged 3 commits into from
Aug 9, 2018

Conversation

ricardogobbosouza
Copy link
Contributor

@ricardogobbosouza ricardogobbosouza commented Aug 9, 2018

The rule expect-expect was not included

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind removing the fixable badge, and I'll merge 🙂

README.md Outdated
@@ -81,6 +81,7 @@ for more information about extending configuration files.
| Rule | Description | Recommended | Fixable |
| ---------------------------- | ----------------------------------------------------------------- | ---------------- | ------------------- |
| [consistent-test-it][] | Enforce consistent test or it keyword | | ![fixable-green][] |
| [expect-expect][] | Enforce assertion to be made in a test body | | ![fixable-green][] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not fixable

@ricardogobbosouza
Copy link
Contributor Author

Sorry, my bad! :/

@SimenB SimenB merged commit 3aa7c99 into jest-community:master Aug 9, 2018
@SimenB
Copy link
Member

SimenB commented Aug 9, 2018

No worries! Thanks for fixing it 🙂

@SimenB
Copy link
Member

SimenB commented Aug 9, 2018

🎉 This PR is included in version 21.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants