feat(valid-expect): allow calling expect with no arguments
#1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
force-pushed
the
valid-expect-minArgs-0
branch
from
3a7fed7 to
53f6330
Compare
sonnyp
changed the title
|
thanks, I'm happy with this but will probably wait until after the holidays to land this to give the link checker a chance to come right (seems to be unhappy with https://eslint.org/docs/latest/use/core-concepts#rule-suggestions which looks bonked anyway, and is generated by |
This is particularly useful for jest-extended - https://jest-extended.jestcommunity.dev/docs/matchers/pass - https://jest-extended.jestcommunity.dev/docs/matchers/fail
G-Rath
force-pushed
the
valid-expect-minArgs-0
branch
from
53f6330 to
d361eee
Compare
G-Rath
approved these changes
Jan 15, 2025
G-Rath
changed the title
expect with no arguments
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
# [28.11.0](v28.10.1...v28.11.0) (2025-01-15) ### Features * **valid-expect:** allow calling `expect` with no arguments ([#1688](#1688)) ([ff0349e](ff0349e))
|
🎉 This PR is included in version 28.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly useful for jest-extended