Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prefer expect assertion rule docs #49

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Prefer expect assertion rule docs #49

merged 3 commits into from
Jan 9, 2018

Conversation

tushardhole
Copy link
Contributor

  • Updated README
  • Added prefer-expect-assertions.md

@tushardhole
Copy link
Contributor Author

@SimenB looks like some network issue with CI, can you please re-trigger the failed jobs, if it helps!

Also please review the documentation changes.

@SimenB
Copy link
Member

SimenB commented Jan 9, 2018

Probably Meltdown patching

@SimenB
Copy link
Member

SimenB commented Jan 9, 2018

I'll check in after https://www.traviscistatus.com/incidents/7k5kpkcldbnk is done.

The changes look fine, I just don't wanna deal with unstable CI right now 🙂

@SimenB SimenB merged commit d96baca into jest-community:master Jan 9, 2018
@dependencies dependencies bot mentioned this pull request Jan 9, 2018
Merged
@tushardhole tushardhole deleted the prefer_expect_assertions_docs branch January 10, 2018 06:38
@dependencies dependencies bot mentioned this pull request Jan 31, 2018
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 14, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushardhole @SimenB