valid-describe: warn if first argument is a function

[macklinu]

From #57 (comment)

Report in the valid-describe rule for the following case:

describe(() => {})

[SimenB]

Also see jestjs/jest#5493

[macklinu]

I'll open a PR for this.

[brianlmacdonald]

Can I call dibs on this?

[macklinu]

@brianlmacdonald go for it - thanks!

I noticed that the valid-describe rule falsely reports this as valid:

eslint-plugin-jest/rules/__tests__/valid-describe.test.js

Line 14 in 5e01e6b

'describe("foo")',

when I believe that describe() always requires two parameters (name: string, fn: Function), which is something I missed in #57.

If you're feeling up for correcting that test case in your PR, that would be awesome too. 😄

[brianlmacdonald]

Hey @macklinu, I added the appropriate warnings and tests-- the messages are as follows [message: 'First argument must be name', 'message: 'Describe requires name and callback arguments'']. Happy to change them to any house style verabe if you'd rather before I put in the PR.

Also, I'm not familiar with husky or commitmsg-- can you tell me what these warnings are referring too so I can fix them?
✖ message may not be empty [subject-empty]
✖ type may not be empty [type-empty]

Hope you're having a good Saturday!

[SimenB]

The commit message must follow the form of "feat: some added feature". We use these semantic commits to publish from CI.

See http://karma-runner.github.io/2.0/dev/git-commit-msg.html

[brianlmacdonald]

Ok, thanks!

[macklinu]

Resolved in #65. Closing.