feat(rule): add no-hooks rule #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklinu
commented
Feb 12, 2018
rules/no-hooks.js
Outdated
| if (isHook(node) && !isWhitelisted(node)) { | ||
| context.report({ | ||
| node, | ||
| message: 'Unexpected setup/teardown hook', |
There was a problem hiding this comment.
Should the message including the hook name (e.g. beforeEach), or is this sufficient?
There was a problem hiding this comment.
I'm going to include the hook name in the error message. 👍
macklinu
force-pushed
the
rule/no-hooks
branch
from
989ab73 to
9420a9f
Compare
|
This is ready for review. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #72