Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No jest import fixes #99

Merged
merged 3 commits into from
Mar 10, 2018
Merged

No jest import fixes #99

merged 3 commits into from
Mar 10, 2018

Conversation

ranyitz
Copy link
Contributor

@ranyitz ranyitz commented Mar 10, 2018

Following to #98, This PR:

  • Add no-jest-import rule to the README.md.
  • Make it recommended.
  • Set error level to warn.

@SimenB
Copy link
Member

SimenB commented Mar 10, 2018

Technically it's a breaking change adding it to recommended, but if people do import jest then it doesn't work, so it might be OK.

@thymikee thoughts?

@thymikee
Copy link
Member

I'd rather say it's a fix, being breaking at the same time. I'm OK with adding it to the next minor/patch

@SimenB
Copy link
Member

SimenB commented Mar 10, 2018

🤞

@SimenB SimenB merged commit fb54759 into jest-community:master Mar 10, 2018
@SimenB
Copy link
Member

SimenB commented Mar 10, 2018

🎉 This PR is included in version 21.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants