From e25c906b447f9032bf88692995db90bc50083fe6 Mon Sep 17 00:00:00 2001 From: Ricardo Gobbo de Souza Date: Thu, 9 Aug 2018 15:42:41 -0300 Subject: [PATCH 1/3] fix(rules): add `expect-expect` --- index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/index.js b/index.js index a1ffd926b..87a3bb071 100644 --- a/index.js +++ b/index.js @@ -1,6 +1,7 @@ 'use strict'; const consistentTestIt = require('./rules/consistent-test-it'); +const expectExpect = require('./rules/expect-expect'); const lowercaseName = require('./rules/lowercase-name'); const noDisabledTests = require('./rules/no-disabled-tests'); const noFocusedTests = require('./rules/no-focused-tests'); @@ -67,6 +68,7 @@ module.exports = { }, rules: { 'consistent-test-it': consistentTestIt, + 'expect-expect': expectExpect, 'lowercase-name': lowercaseName, 'no-disabled-tests': noDisabledTests, 'no-focused-tests': noFocusedTests, From 773a4582c319a17c619f1e5b5f353f35a09d5237 Mon Sep 17 00:00:00 2001 From: Ricardo Gobbo de Souza Date: Thu, 9 Aug 2018 15:50:58 -0300 Subject: [PATCH 2/3] docs(readme): add `expect-expect` rule --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 516e0d4e2..d677fdf11 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,7 @@ for more information about extending configuration files. | Rule | Description | Recommended | Fixable | | ---------------------------- | ----------------------------------------------------------------- | ---------------- | ------------------- | | [consistent-test-it][] | Enforce consistent test or it keyword | | ![fixable-green][] | +| [expect-expect][] | Enforce assertion to be made in a test body | | ![fixable-green][] | | [lowercase-name][] | Disallow capitalized test names | | ![fixable-green][] | | [no-disabled-tests][] | Disallow disabled tests | ![recommended][] | | | [no-focused-tests][] | Disallow focused tests | ![recommended][] | | @@ -106,6 +107,7 @@ for more information about extending configuration files. - [eslint-plugin-jasmine](https://github.com/tlvince/eslint-plugin-jasmine) [consistent-test-it]: docs/rules/consistent-test-it.md +[expect-expect]: docs/rules/expect-expect.md [lowercase-name]: docs/rules/lowercase-name.md [no-disabled-tests]: docs/rules/no-disabled-tests.md [no-focused-tests]: docs/rules/no-focused-tests.md From 92961d9f620470b5bc9ccae2a2e671d1b6f3609b Mon Sep 17 00:00:00 2001 From: Ricardo Gobbo de Souza Date: Thu, 9 Aug 2018 17:24:29 -0300 Subject: [PATCH 3/3] docs(readme): removed fixable marker --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d677fdf11..4675ecd60 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ for more information about extending configuration files. | Rule | Description | Recommended | Fixable | | ---------------------------- | ----------------------------------------------------------------- | ---------------- | ------------------- | | [consistent-test-it][] | Enforce consistent test or it keyword | | ![fixable-green][] | -| [expect-expect][] | Enforce assertion to be made in a test body | | ![fixable-green][] | +| [expect-expect][] | Enforce assertion to be made in a test body | | | | [lowercase-name][] | Disallow capitalized test names | | ![fixable-green][] | | [no-disabled-tests][] | Disallow disabled tests | ![recommended][] | | | [no-focused-tests][] | Disallow focused tests | ![recommended][] | |