Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix features since nightly-2018-08-14 disallowed old features #25

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Fix features since nightly-2018-08-14 disallowed old features #25

merged 2 commits into from
Jun 7, 2019

Conversation

parasyte
Copy link
Contributor

Fixes #20

@parasyte
Copy link
Contributor Author

@jethrogb It worked‼️

@parasyte
Copy link
Contributor Author

parasyte commented May 15, 2019 •
edited
Loading

Some additional notes: I added feature(nll) with bind_by_move_pattern_guards only because it's required starting with nightly-2019-02-25. I think rust-lang/rust#59192 removed the need for the nll feature with bind_by_move_pattern_guards, but I haven't tested. And since nll is still accepted by recently nightlies, I didn't see a reason to add more conditions.

This might be further addressed by rust-lang/rust#57895 in the future ...

@parasyte
Copy link
Contributor Author

Ping @jethrogb I would like to get this merged so I can also address #19; I have a patch staged for that, it depends on fixing the build (this PR).

@parasyte
Copy link
Contributor Author

@jethrogb Sorry to bother, but this is ready for review.

I'm also considering taking up the maintainer role (#15) since I'm planning on depending on this crate soon. This might be a bit off-topic for the ticket, but I will need something like core_io until I can port std to my target. And I don't expect that to happen any time soon. The portability WG repo hasn't seen a lot of activity lately. :)

jethrogb
jethrogb reviewed Jun 3, 2019
View reviewed changes
Copy link
Owner

@jethrogb jethrogb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Mostly LGTM, but a few comments.

@jethrogb
Copy link
Owner

jethrogb commented Jun 7, 2019

bors r+

bors bot added a commit that referenced this pull request Jun 7, 2019
@bors @parasyte
Merge #25
dc39fb4 
25: Fix features since nightly-2018-08-14 disallowed old features r=jethrogb a=parasyte

Fixes #20 

Co-authored-by: Jay Oster <jay@pubnub.com>
Co-authored-by: Jay Oster <jay@kodewerx.org>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit f390668 into jethrogb:master Jun 7, 2019
@parasyte parasyte deleted the fix/ticket-20 branch June 7, 2019 07:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jethrogb jethrogb jethrogb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add #![feature(alloc)], when enabling collections and/or alloc feature
2 participants
@parasyte @jethrogb