Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Is there a changelog somewhere? #32

Closed
jim-cooper opened this issue Jan 8, 2018 · 5 comments
Closed

Is there a changelog somewhere? #32

jim-cooper opened this issue Jan 8, 2018 · 5 comments

Comments

@jim-cooper
Copy link

Is there a changelog or release notes somewhere? I don't know if it's safe to upgrade from 1.1.0 to 2.0.2. Thanks.

@ChrisWestcottUK
Copy link

I can see that there is now a version 3.0.0 but also can't find a changelog. Assuming semantic versioning, I would expect to see breaking changes, but I don't have any idea what these may be.

@jfromaniello
Copy link
Owner

There isn't a changelog yet.

v3 should be compatible with v2 for most common cases and it fixes some issues. But the truth is that v2 was missing a lot of tests so I wanted this to be a conscious decision.

@ChrisWestcottUK
Copy link

Thank you for the response José. In my application testing I'm not seeing any breaking changes.

Proper use of semantic versioning does make it much easier for those of us using your library in assessing impact to our code bases.

@jfromaniello
Copy link
Owner

@ChrisWestcottUK understand and I use semantic versioning with all my libraries.. This is what it has been fixed between v2 and v3:

https://github.com/jfromaniello/url-join/pull/35/files

IMHO this should have been a patch actually, but these things where broken for so long that I was afraid other people where relying on broken/undesired behavior.

my apologies

@ChrisWestcottUK
Copy link

@jfromaniello no need to apologise and thank you for providing the diff here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants