Fix bulma color brightness #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using all channels of the colour to approximate brightness, this function was sublty ignoring the blue channel and over-stating other channels.
|
Oh wow, good catch! That was definitely an error, since the W3 recommendation I was refering to does have the extra set of brackets: https://www.w3.org/TR/AERT/#color-contrast The formula should be:
This correction will definitely change things. And I wonder if my error did alter my judgment when developing v1. I'm gonna check out your branch and see how this looks. Many thanks in any case. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Proposed solution
Previously, the bulmaColorBrightness function was understating the value of the blue channel when estimating brightness for a specific colour, due to a missing set of brackets. This just corrects the brackets so that all channels of the colour are weighted, instead of just red and green.
Additionally, I've switched from the slash division operation which is deprecated in Sass, to the math.div operator.
Tradeoffs
Some folks may be relying on the slightly odd behaviour, though with blue being the least significant channel for brightness this will be an edge case and will likely be a producing confusing rules with the current implementation.
Testing Done
Ran the docs site and visually compared a variety of buttons, panels, box, and theme pages to ensure no difference. Using the default theming values, validated that there are no differences before and after this change in the output css.
Changelog updated?
No, but happy too if that's a good idea.