[FEATURE] Cache combinedStyles #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. If you remove the trailing space (thus making the build pass), I'll directly merge it. ❤️ (I would need to create an new PR if I wanted to edit a PR from a fork. So it's less work for me if you do the change.) |
|
By the way, you can configure most IDEs (including PhpStorm) to automatically drop any trailing whitespace on saving a file. |
vanderlee
force-pushed
the
cache-combinedstyles
branch
from
bbe41c2 to
5f5ac08
Compare
vanderlee
force-pushed
the
cache-combinedstyles
branch
from
5f5ac08 to
eb7a8b2
Compare
|
Squashed and somehow had to fix a totally new /r/n error on a line I never touched (the very first). |
oliverklee
added a commit
that referenced
this pull request
Jul 11, 2015
[FEATURE] Cache combinedStyles
|
Merged. @vanderlee Thanks a lot for this PR! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #208, but on current master.
The current master with the short array fix caused so much changes that it was easier to just start anew with this feature than try to resolve all the conflicts.
I also added the clearing of the cache, which decreases performance gains somewhat: back to ~20% from ~30%.