Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Set default CSV delimiter to Moodle Configuration #196

Closed
mvaraujo opened this issue Jan 3, 2022 · 0 comments
Closed

Set default CSV delimiter to Moodle Configuration #196

mvaraujo opened this issue Jan 3, 2022 · 0 comments

Comments

@mvaraujo
Copy link
Contributor

mvaraujo commented Jan 3, 2022

The CSV export does not set a delimiter when instantiating csv_export_writer. Hence the API assumes comma:

Here in Brazil, Excel "prefers" semicolon, and I propose that this instantiation set cfg as the delimiter.

If the setting is not present in the Moodle configuration file, the API will fall back to comma:
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSV delimiter from Moodle Configuration closes #196 mvaraujo/moodle-block_configurablereports
1 participant
@mvaraujo