Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

several rules are showing as deprecated #57

Closed
jmecosta opened this issue Jun 15, 2019 · 8 comments
Closed

several rules are showing as deprecated #57

jmecosta opened this issue Jun 15, 2019 · 8 comments
Assignees

Comments

@jmecosta
Copy link
Owner

@milbrandt do u have the same?

image

@milbrandt
Copy link
Collaborator

Unfortunately yes, and all rules are marked as major in 1.0.6.122.
In 1.0.6.110 there where already the same number of deprecated rules, but with information as severity level.

Maybe there is also a predefined alternative for giving the severity string in each call of activateRule. Otherwise we should introduce an enumeration of strings for the severity levels.

screenshot1-0-6-110

@milbrandt
Copy link
Collaborator

released 1.0.5 and even the old 1.0.3 (Oct 2018) have the same behavior as 1.0.6.110

@milbrandt
Copy link
Collaborator

milbrandt commented Jun 16, 2019

org.sonar.api.rule.Severity contails al the supported severity values, see Plugin API

@milbrandt
Copy link
Collaborator

In org.sonar.plugins.fsharp.FSharpSonarRulesDefinition, lines 191 ff., the rule names for several rules are set explicitly to deprecated rule. These rules were added on Feb 20, 2018 in commit 3a48475

@milbrandt milbrandt self-assigned this Jun 16, 2019
@jmecosta
Copy link
Owner Author

ok, so lets remove them since they have been deprecated for a while. i remenber this was done when there was a major refactoring in fsharplint

@milbrandt
Copy link
Collaborator

There are several rules in FSharpSonarRulesDefinition which aren't included FSharpSonarWayProfile. Have you deprecated them long ago?
I created a branch for some refactoring the above and observed now these additional rules like RulesNamingConventionsTypesError.

@jmecosta
Copy link
Owner Author

i think at least more than a year! anwyay, fharp lint will not produce those anymore so we should just remove them.

@milbrandt
Copy link
Collaborator

removed in v1.1.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants