Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added PHParrot #399

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Added PHParrot #399

merged 2 commits into from
Oct 6, 2019

Conversation

Mindflayo
Copy link
Contributor

No description provided.

Copy link
Owner

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak and we should be good to merge 👍

parrots.json Outdated
@@ -674,5 +674,10 @@
"gif": "databaseparrot.gif",
"name": "Database Parrot",
"tip": "To sql or not to sql"
},
{
"gif": "hd/phparrot.gif",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this key actually needs to be "hd": "hd/phpparrot.gif" to get tests passing and the build working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, fixed

@jmhobbs jmhobbs merged commit 73986b4 into jmhobbs:master Oct 6, 2019
@jmhobbs
Copy link
Owner

jmhobbs commented Oct 6, 2019

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants