Change links to use HTTPs #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zschallz
commented
Oct 19, 2019
zschallz
commented
- Changed template links to use HTTPS
- Added a test to ensure http:// isn't referenced anywhere in the templates unless it's whitelisted.
…s unless they're whitelisted
zschallz
commented
Oct 19, 2019
| @@ -182,7 +182,6 @@ <h3>Discord</h3> | |||
| <p> | |||
| <a class="button-small" href="https://github.com/jmhobbs/terminal-parrot">Terminal</a> | |||
| <a class="button-small" href="https://github.com/Shrugs/partyparrot">Text-To-Parrots</a> | |||
| <a class="button-small" href="http://countryparrots.com/">Country Parrots</a> | |||
There was a problem hiding this comment.
This is a dead link, so I removed it.
zschallz
commented
Oct 19, 2019
| @@ -211,15 +210,15 @@ <h3>Discord</h3> | |||
| </p> | |||
|
|
|||
| <p> | |||
| <a class="button-small" href="http://kakaporecovery.org.nz/sirocco/">Donate To Keep Them Partying</a> | |||
| <a class="button-small" href="https://www.doc.govt.nz/kakapo-recovery">Donate To Keep Them Partying</a> | |||
There was a problem hiding this comment.
Domain kakaporecovery.org.nz doesn't seem to have an https certificate, but the link redirects to www.doc.govt.nz anyway, which does.
zschallz
commented
Oct 19, 2019
| fileContents | ||
| .toString() | ||
| .match(/(http:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*))/gi); | ||
| httpLinks = httpLinks ? httpLinks : []; |
There was a problem hiding this comment.
.match() returns null, but it's easier to deal with an empty array.
|
Top notch stuff, thanks for the effort on this! |
zschallz
commented
Oct 19, 2019
|
|
||
| describe("HTML templates", function() { | ||
| it("should not contain un-whitelisted http://", function() { | ||
| const whiteList = ['http://www.gtfoparrot.com/']; |
There was a problem hiding this comment.
No choice here- gtfoparrot is hosted on google storage and has no HTTPS cert.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.