Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed jediparrot and sithparrot #563

Merged
merged 3 commits into from
Jun 22, 2021
Merged

fixed jediparrot and sithparrot #563

merged 3 commits into from
Jun 22, 2021

Conversation

ishaanharry
Copy link
Contributor

Originally, the gifs would unintentionally leave a trail of images on Discord. These gifs should not do that.

When uploaded to Discord, the gif unintentionally leaves a trail of images. Will upload a fixed gif.
When uploaded to Discord, the gif unintentionally leaves a trail of images. Will upload a fixed gif.
Previous gifs would leave a trail of images when uploaded to Discord.  The issue is fixed with these gifs.
@jmhobbs
Copy link
Owner

jmhobbs commented Jun 22, 2021

Thanks for the fix! What was the reasoning, maybe we can add a test?

@jmhobbs jmhobbs merged commit 0415384 into jmhobbs:master Jun 22, 2021
@ishaanharry
Copy link
Contributor Author

Thanks for the fix! What was the reasoning, maybe we can add a test?

I don't really know what the issue was. I just used a gif optimizer to compress the file sizes which seemed to fix the error. I have no idea why the original gifs appeared scuffed on Discord and nowhere else.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants