Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Resonating Red Parrot for Hacktoberfest! #643

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

WeiJian123-tech
Copy link
Contributor

Here is my parrot GIF that I created with Photpea for Hacktoberfest. I couldn't find any static jpgs or pngs for blue and green parrot so I went with red parrot which was readily available from https://cultofthepartyparrot.com as the first frame.

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 10, 2023

I dig it! But the full re-formatting of the YAML file is a bit much, can you make it so that only has your addition as the change? Thanks!

@WeiJian123-tech
Copy link
Contributor Author

I redownloaded the parrots.yaml file from your main GitHub branch and reentered Resonating Red Parrot's .yaml information without reformatting the entire parrots.yaml file. Sorry about that. I thought I had to deploy as a step before contributing so I npm installed cultofthepartyparrot. It might have been me running npm that changed parrots.yaml file's format but I am not entirely sure.

image

Is this a good fix even though my check now fail?

WeiJian123-tech and others added 4 commits October 11, 2023 09:56
Created Resonating Red Parrot GIF for Hacktoberfest!
I redownloaded the original `parrots.yaml` file from cultofthepartyparrot.com's main GitHub Branch and added my Resonating Red Parrot information back in. It should only have added Resonating Red Parrot information without reformatting the whole file.
@jmhobbs
Copy link
Owner

jmhobbs commented Oct 11, 2023

Hey @WeiJian123-tech, no worries, I'm not sure what went wrong there. I hope you don't mind, I cleaned up the conflicts so that this would deploy and we could merge it.

Thanks for adding this parrot!

@jmhobbs jmhobbs merged commit 41c531d into jmhobbs:main Oct 11, 2023
3 checks passed
@WeiJian123-tech
Copy link
Contributor Author

That is quite alright. I really don't mind. It was fun creating and contributing a cultoftheparrot.com parrot .gif. 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants