Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AsciiStringRef / UTF8StringRef memory safety concerns #285

Open
charleskorn opened this issue Nov 23, 2021 · 0 comments
Open

AsciiStringRef / UTF8StringRef memory safety concerns #285

charleskorn opened this issue Nov 23, 2021 · 0 comments

Comments

@charleskorn
Copy link
Contributor

charleskorn commented Nov 23, 2021 •
edited
Loading

From #276:

I'm not sure if my changes are correct though:

  • should UTFStringRef.set() also update this.length to the length of the new string value?
  • should we be allocating additional space for the null terminator character in the call to getRuntime().getMemoryManager().allocateDirect()?
@charleskorn charleskorn changed the title AsciiStringRef / UTF8StringREf AsciiStringRef / UTF8StringRef memory safety concerns Nov 23, 2021
@charleskorn charleskorn mentioned this issue Nov 23, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charleskorn