Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

mypy GitHub Action #25

Closed
joaonc opened this issue Jan 24, 2022 · 0 comments · Fixed by #27
Closed

mypy GitHub Action #25

joaonc opened this issue Jan 24, 2022 · 0 comments · Fixed by #27
Assignees
@joaonc
Labels
infrastructure Make things work smoothly

Comments

@joaonc
Copy link
Owner

joaonc commented Jan 24, 2022

PR #24 for issue #14 didn't add mypy as part of the linting being done in CI, because the whole project needed to be installed and that GH Action is only installing the packages in lint-requirements.txt.

Solutions:

  1. Install all packages for linting.
  2. Run mypy in a separate GH Action
    2.1 Use composite GH Actions to install the whole project only once and have faster CI.
@joaonc joaonc self-assigned this Jan 24, 2022
@joaonc joaonc added the infrastructure Make things work smoothly label Jan 24, 2022
@joaonc joaonc moved this from Todo to In Progress in HD Active Jan 24, 2022
@joaonc joaonc mentioned this issue Jan 24, 2022
Merged
Repository owner moved this from In Progress to Done in HD Active Jan 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@joaonc joaonc

Labels
infrastructure Make things work smoothly
Projects
HD Active
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mypy GitHub Action joaonc/hd_active
1 participant
@joaonc