Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: consistent media query ordering, fixes #2 #6

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

johanneslumpe
Copy link
Owner

This PR ensures that media query ordering is consistent based on the defined order within a theme and not the responsive object passed to a component.

@codecov-io
Copy link

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          31     32    +1     
  Branches       10     11    +1     
=====================================
+ Hits           31     32    +1
Impacted Files Coverage Δ
src/style.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87e552...a52ec22. Read the comment docs.

@johanneslumpe johanneslumpe merged commit 3d0e214 into master Aug 14, 2018
@johanneslumpe johanneslumpe deleted the fix/media-query-ordering branch August 14, 2018 01:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants