Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: make theme optional, return early if no theme or breakpoints present #7

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

johanneslumpe
Copy link
Owner

theme should really be optional/not required if consumers do not pass in an interface for it. This change enforces that no theme be passed in in that case. It also fixes an issue with tsconfig.json and vscode not being able to find it due to an incorrect name.

@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          31     33    +2     
  Branches       11     12    +1     
=====================================
+ Hits           31     33    +2
Impacted Files Coverage Δ
src/style.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8768960...e1b200d. Read the comment docs.

@johanneslumpe johanneslumpe merged commit 99f7410 into master Aug 15, 2018
@johanneslumpe johanneslumpe deleted the fix/typings_and_early_return branch August 15, 2018 03:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants