Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Turn off facet labels #39

Open
johnmackintosh opened this issue Jan 26, 2022 · 2 comments
Open

Turn off facet labels #39

johnmackintosh opened this issue Jan 26, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@johnmackintosh
Copy link
Owner

johnmackintosh commented Jan 26, 2022

The package was always designed to produce multiple charts at once, so having facet labels by default makes perfect sense.

However, for reporting of individual metrics, it would be good to be able to turn off the facet label when only one chart/ group is present.

The easiest way would be to add another parameter and put the onus on the user to set it to FALSE as required ..
facet_labels = TRUE

alternatively, a check to count groups and ask the user if they want them turned off?
Personally, I don't want my code to be interrupted to ask for confirmation when its run as part of a scheduled task - so option 1 seems right

@johnmackintosh johnmackintosh added the enhancement New feature or request label Jan 26, 2022
@johnmackintosh johnmackintosh self-assigned this Jan 26, 2022
@johnmackintosh
Copy link
Owner Author

  • function documentation
  • unit tests
  • readme examples
  • articles

@johnmackintosh
Copy link
Owner Author

theme(strip.text = element_blank())

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant