You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it will make everything less confusing and more manageable if we aren't mapping launch variables directly to variables in dependencies. We should define the launch.json in a way that is understandable, and then map them to their dependency counterparts inside of launch.
I propose we prepend all variables with LAUNCH_, and then name the variables things that make more sense to the end user.
We can take this, and remap them as necessary inside of launch. This will avoid most conflicts with other tools and their environment variables. But, it does feel a little verbose.
We could also prepend LAUNCH_ to each variable when launch reads the file. This way, we avoid conflicts with other tools, and become a little more succinct. However, I think this would make it a little more confusing to override the variables in a CI environment.
The text was updated successfully, but these errors were encountered:
I think it will make everything less confusing and more manageable if we aren't mapping launch variables directly to variables in dependencies. We should define the
launch.json
in a way that is understandable, and then map them to their dependency counterparts inside of launch.I propose we prepend all variables with
LAUNCH_
, and then name the variables things that make more sense to the end user.We can take this, and remap them as necessary inside of launch. This will avoid most conflicts with other tools and their environment variables. But, it does feel a little verbose.
We could also prepend
LAUNCH_
to each variable when launch reads the file. This way, we avoid conflicts with other tools, and become a little more succinct. However, I think this would make it a little more confusing to override the variables in a CI environment.The text was updated successfully, but these errors were encountered: