feat: enable sash size to be customised in code #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for allotment-storybook ready! 🔨 Explore the source changes: f86ee25 🔍 Inspect the deploy log: https://app.netlify.com/sites/allotment-storybook/deploys/61c89782e6cf760007a9276d 😎 Browse the preview: https://deploy-preview-101--allotment-storybook.netlify.app |
|
It would be nice to give an example where dragging the sash on mobile does not cause the contents of panes to be selected. |
johnwalley
changed the title
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently sets the sash size globally for all Allotment components. Obviously, setting a prop on a React component should only affect that component. We can either address this in this PR or leave this undocumented for now and tidy up in a follow-up PR.