Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

go-to-definition sometimes lands on the wrong line (but correct file, at least) #22

Open
1 task done
jokeyrhyme opened this issue Oct 10, 2023 · 4 comments
Open
1 task done

go-to-definition sometimes lands on the wrong line (but correct file, at least) #22

jokeyrhyme opened this issue Oct 10, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@jokeyrhyme
Copy link
Owner

jokeyrhyme commented Oct 10, 2023 •
edited
Loading

  • we've noticed that go-to-definition isn't always very accurate in terms of row/column
  • need to double-check the behaviour of the the VSCode extension in real VSCode
@jokeyrhyme jokeyrhyme added the bug Something isn't working label Oct 10, 2023
@jokeyrhyme
Copy link
Owner Author

Without any actual investigation, I do wonder if this is related to #10 ?

@jokeyrhyme
Copy link
Owner Author

I cannot reproduce this issue in https://github.com/nushell/vscode-nushell-lang 1.7.0 with Visual Studio Code 1.83.0

So, the issue is somewhere in nuls

@jokeyrhyme
Copy link
Owner Author

Hmmm, the document contents are stored in String and str types (UTF-8) in various places, but all the offsets are for UTF-16 content, and I think this might be an area that needs to be investigated

@jokeyrhyme
Copy link
Owner Author

I can confirm that this is happening in Visual Studio Code, and not just helix

@jokeyrhyme jokeyrhyme mentioned this issue Oct 17, 2023
Draft
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jokeyrhyme