Race Conditions

[stefanpenner]

• https://github.com/jonkemp/qunit-phantomjs-runner/blob/master/runner.js#L44 can run before https://github.com/jonkemp/qunit-phantomjs-runner/blob/master/runner.js#L66
• https://github.com/jonkemp/qunit-phantomjs-runner/blob/master/runner.js#L98 can run before QUnit loads

Solution is most likely to do the following:

• disable QUnit autostart
• onload:
  • attach logger
  • manually start tests via QUnit.start()

@trentmwillis thoughts on the QUnit side? If you have a better idea for coordinating the runner + qunit boot.

[trentmwillis]

From my cursory glance, it seems like disabling autostart is the best way to go. Lots of async setup going on it seems.

[stefanpenner]

@trentmwillis is there a way to set that configurable before QUnit is loaded?

[trentmwillis]

Unfortunately no, at least no way that I am aware of.

[stefanpenner]

@trentmwillis any apposition to me submitting a PR for it?

[trentmwillis]

For pre-configuring QUnit? I'm not opposed, but we'd probably want to open it up for discussion with the rest of the team to determine an API

[stefanpenner]

@trentmwillis maybe a meta tag? Ya, i'll try to open a discussion later this week.