Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integrate package.json validator output? #9

Open
pdehaan opened this issue Mar 29, 2014 · 2 comments
Open

Integrate package.json validator output? #9

pdehaan opened this issue Mar 29, 2014 · 2 comments
Labels

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Mar 29, 2014

Since this alters the package.json file quite a bit in some cases, not sure if you want to add some more debug output after rewriting the package.json file.

Relevant: https://github.com/gorillamania/package.json-validator

For example, after rewriting the package.json file, maybe just a brief few lines of output saying:

package.json file valid: false
errors:

  • bugs field should have one of: email, url, mail, web
  • licenses field should have url
  • author field should have name
@jonschlinkert
Copy link
Owner

Not a bad idea. After you pointed the validator out initially it had crossed my mind, but I dismissed because (ahem) I didn't want some of the fields to be "technically" valid lol. Sorry, just being honest. I don't like the idea of encouraging the use of strings on some of the fields. However! If we implement "modes", we can have a strict mode that makes everyone happy.

Sound okay?

@pdehaan
Copy link
Contributor Author

pdehaan commented Mar 29, 2014

(╯°□°)╯︵ ┻━┻

Sure, sounds fine. As long as npm accepts the package.json, it's all good.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants