Here's the best order of steps to upstreaming changes.
-
Send a PR to jsoo upstream to break out
Id.re
andLoc.re
(we should probably convert them to.ml
before sending the PR). -
Remove the ability for javascript.ml to contain
Id.t
in its tree. It won't be needed anymore, becauseId.t
contains data from the bytecode extraction, which now would be entirely inRehp
.javascript.ml
could make do with justident_string
in its AST. (That requires small changes to the js parser). We'll already make this change for thephp.re
AST since it's at a similar layer of the toolchain asjavascript.ml
.