Fix failing on existing Git comment char #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see one failing check but it fails only on 2.7 and this check is not related to my code. |
As soon as _git function returns string if it was executed (not sh.RunningCommand) **get_commentchar** functions fails with AttributeError (could not get exit_code).
torwald-sergesson
force-pushed
the
master
branch
from
d599b0f to
f2ecee9
Compare
|
Hi! |
|
Not sure when this actually occurs, but the code itself can't hurt, so merging this. FYI that I'm not immediately planning on rolling another release - so you'll need to install from git if you want your team to use the version with this fix. |
|
Thanks for your interest! |
|
Related issue: #70 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as _git function returns string if it was executed (not sh.RunningCommand) get_commentchar
functions fails with AttributeError (could not get exit_code).