Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for binary stars in space #9

Open
jorisvddonk opened this issue Aug 18, 2023 · 1 comment
Open

Add support for binary stars in space #9

jorisvddonk opened this issue Aug 18, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jorisvddonk
Copy link
Owner

Binary stars in Noctis IV can be pretty exciting. It'd be nice if they're properly supported, i.e. if the "planet class" 11 ("Companion star - not a planet.") shows as a proper star in space as well.

This very likely only requires changes in the Godot project - and not changes in feltyrion-godot -, hence why it's marked as a "good first issue". That said, it may be a good idea to do some larger refactoring to ensure that stars and companion stars both use some new internal scene dedicated to displaying in-system stars. Whomever picks this issue up may want to spend some time understanding the current scene layout and project structure.

@jorisvddonk jorisvddonk added enhancement New feature or request good first issue Good for newcomers labels Aug 18, 2023
@jorisvddonk
Copy link
Owner Author

jorisvddonk commented Aug 18, 2023

An initial version doesn't have to be perfect; as long as it shows a star that visually looks like any other star, I'll accept a PR! We can make stars look more accurate or exciting later.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant