Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PHP 8.0 support #35

Merged
merged 1 commit into from
Oct 21, 2022
Merged

PHP 8.0 support #35

merged 1 commit into from
Oct 21, 2022

Conversation

joseluisq
Copy link
Owner

@joseluisq joseluisq commented Oct 21, 2022

This PR adds PHP 8.0 support.
It was tested successfully with PHP 8.0 via Docker.

docker run --rm -it -v $PWD:/var/www/html joseluisq/php-fpm:8.0 \
  sh -c 'composer install && vendor/bin/phpunit'

Note: PHP 8.1 support could come later via a new PR.

it tested successfully with php 8.0 via docker:

docker run --rm -it -v $PWD:/var/www/html joseluisq/php-fpm:8.0 bash -c 'composer install && vendor/bin/phpunit'
@joseluisq joseluisq marked this pull request as ready for review October 21, 2022 01:06
@joseluisq
Copy link
Owner Author

@ssheduardo here is the initial draft PR for adding PHP 8.0. It works in general with just a minor fix on the tests.
But it is necessary to bump up to 7.4 as the minimum PHP version required via composer.json.

PHP 8.1 will give more test problems but they can be solved in a second PR.

@joseluisq joseluisq marked this pull request as draft October 21, 2022 01:14
@ssheduardo
Copy link

Hola, tienes algún correo u otro medio para comunicarme contigo?

@ssheduardo
Copy link

Hi,
When run the command:

docker run --rm -it -v $PWD:/var/www/html joseluisq/php-fpm:8.0 \
  bash -c 'composer install && vendor/bin/phpunit'

The docker response:
image

But if I change bash to sh, the command no show the error.

image

Run test is OK

@joseluisq
Copy link
Owner Author

Hola, tienes algún correo u otro medio para comunicarme contigo?

Puede usar mi cuenta Keybase para chat directo. https://joseluisq.net my usuario es joseluisq

@joseluisq
Copy link
Owner Author

But if I change bash to sh, the command no show the error.

Yes, fixed in the description.

@joseluisq joseluisq marked this pull request as ready for review October 21, 2022 15:45
@joseluisq joseluisq merged commit c4a3c1e into master Oct 21, 2022
@joseluisq joseluisq deleted the feature/php8-support branch October 21, 2022 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants