Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lattice issues #128

Open
mjpost opened this issue Jul 26, 2013 · 0 comments
Open

Lattice issues #128

mjpost opened this issue Jul 26, 2013 · 0 comments
Assignees
Milestone

Comments

@mjpost
Copy link
Member

mjpost commented Jul 26, 2013

Joshua truncates sentences to 200 tokens, but turns them into a lattice first and computes the shortest path between all pairs. This causes huge problems for buggy input (e.g., https://groups.google.com/forum/#!topic/joshua_support/-2PykKqbnU4 ). A couple things that should change:

  • Don't apply an O(n^2) algorithm to buggy input. Maybe only call calculateAllPairsShortestPaths() lazily.
  • Compute it more efficiently (for example, if you know the input is just a sentence, you could add some shortcuts)
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant