Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add alternative text to author image #8

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Add alternative text to author image #8

merged 4 commits into from
Jun 17, 2022

Conversation

stphnwlsh
Copy link
Contributor

Getting an accessibilty error on https://wave.webaim.org/report#/stphnwlsh.github.io for missing alt text on the image. This just adds the ability to add alternative text to the theme

@stphnwlsh
Copy link
Contributor Author

@jpanther any thoughts on this PR? Just trying to close out my open ones. If you don't want it, I'm more than happy to close it.

@jpanther
Copy link
Owner

Thanks for reminding me about this one and apologies for not responding sooner. I did miss adding the alt text to this image but I wonder if having it as a separate configuration parameter is necessary? Could it not just use the author's name as the alt value?

@stphnwlsh
Copy link
Contributor Author

Thanks for reminding me about this one and apologies for not responding sooner. I did miss adding the alt text to this image but I wonder if having it as a separate configuration parameter is necessary? Could it not just use the author's name as the alt value?

That's a fair call, just thought I'd give people the option but will change it back.

@stphnwlsh
Copy link
Contributor Author

Okay reverted to just add the name as the alternative text. Also no need to apologise. I'm the one randomly contributing to your work

@jpanther jpanther added the enhancement New feature or request label Jun 17, 2022
@jpanther
Copy link
Owner

Thanks, I'll merge this change in!

@jpanther jpanther merged commit 0848597 into jpanther:dev Jun 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants