Forbid dependencies over call expressions.

Closes llvm#54
Closes llvm#55

Author: mikaoP

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -10888,6 +10888,8 @@ def err_oss_clause_not_arithmetic_type_arg : Error<
 def err_oss_reduction_depend_conflict : Error<
   "variable %0 conflicts between dependency and reduction clause">;
 
+def err_oss_call_expr_support : Error<
+  "call expressions are not supported">;
 def err_oss_expected_addressable_lvalue_or_array_item : Error<
   "expected addressable lvalue expression, array element, array shape or array section">;
 def err_oss_expected_dereference_or_array_item : Error<

clang/lib/Sema/SemaOmpSs.cpp

@@ -3280,14 +3280,61 @@ Sema::ActOnOmpSsDependClause(ArrayRef<OmpSsDependClauseKind> DepKinds, SourceLoc
     //   typedef float V __attribute__((vector_size(16)));
     //   V a;
     //   #pragma oss task in(a[3])
-    if (!RefExpr->IgnoreParenImpCasts()->isLValue() ||
+    // and functions:
+    //   void foo() { #pragma oss task in(foo) {} }
+    if (RefExpr->IgnoreParenImpCasts()->getType()->isFunctionType() ||
+        !RefExpr->IgnoreParenImpCasts()->isLValue() ||
         (ASE &&
          !ASE->getBase()->getType().getNonReferenceType()->isPointerType() &&
          !ASE->getBase()->getType().getNonReferenceType()->isArrayType())) {
       Diag(ELoc, diag::err_oss_expected_addressable_lvalue_or_array_item)
           << RefExpr->getSourceRange();
       continue;
     }
+
+    class CheckCallExpr
+        : public ConstStmtVisitor<CheckCallExpr, bool> {
+    // This Visitor checks the base of the
+    // dependency is over a CallExpr, which is error.
+    // int *get();
+    // auto l = []() -> int * {...};
+    // #pragma oss task in(get()[1], l()[3])
+    public:
+      bool VisitOSSMultiDepExpr(const OSSMultiDepExpr *E) {
+        return Visit(E->getDepExpr());
+      }
+
+      bool VisitOSSArrayShapingExpr(const OSSArrayShapingExpr *E) {
+        return Visit(E->getBase());
+      }
+
+      bool VisitOSSArraySectionExpr(const OSSArraySectionExpr *E) {
+        return Visit(E->getBase());
+      }
+
+      bool VisitArraySubscriptExpr(const ArraySubscriptExpr *E) {
+        return Visit(E->getBase());
+      }
+
+      bool VisitUnaryOperator(const UnaryOperator *E) {
+        return Visit(E->getSubExpr());
+      }
+
+      bool VisitMemberExpr(const MemberExpr *E) {
+        return Visit(E->getBase());
+      }
+
+      bool VisitCallExpr(const CallExpr *E) {
+        return true;
+      }
+    };
+    CheckCallExpr CCE;
+    if (CCE.Visit(RefExpr)) {
+      Diag(ELoc, diag::err_oss_call_expr_support)
+          << RefExpr->getSourceRange();
+      continue;
+    }
+
     bool InvalidArraySection = false;
     while (auto *OASE = dyn_cast<OSSArraySectionExpr>(SimpleExpr)) {
       if (!OASE->isColonForm() && !OSSSyntax) {

clang/test/OmpSs/Sema/release_depend.cpp

@@ -38,7 +38,7 @@ int main(int argc, char **argv, char *env[]) {
   #pragma oss release depend (in : vec[1]) // expected-error {{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss release depend (in : argv[0])
   #pragma oss release depend (in : ) // expected-error {{expected expression}}
-  #pragma oss release depend (in : main)
+  #pragma oss release depend (in : main) // expected-error {{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss release depend(in : a[0]) // expected-error{{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss release depend (in : argv[ // expected-error {{expected expression}} expected-error {{expected ']'}} expected-error {{expected ')'}} expected-note {{to match this '['}} expected-note {{to match this '('}}
   #pragma oss release depend (in : argv[: // expected-error {{expected expression}} expected-error {{expected ']'}} expected-error {{expected ')'}} expected-note {{to match this '['}} expected-note {{to match this '('}}

clang/test/OmpSs/Sema/task_depend.cpp

@@ -38,7 +38,7 @@ int main(int argc, char **argv, char *env[]) {
   #pragma oss task depend (in : vec[1]) // expected-error {{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss task depend (in : argv[0])
   #pragma oss task depend (in : ) // expected-error {{expected expression}}
-  #pragma oss task depend (in : main)
+  #pragma oss task depend (in : main) // expected-error {{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss task depend(in : a[0]) // expected-error{{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss task depend (in : argv[ // expected-error {{expected expression}} expected-error {{expected ']'}} expected-error {{expected ')'}} expected-note {{to match this '['}} expected-note {{to match this '('}}
   #pragma oss task depend (in : argv[: // expected-error {{expected expression}} expected-error {{expected ']'}} expected-error {{expected ')'}} expected-note {{to match this '['}} expected-note {{to match this '('}}

clang/test/OmpSs/Sema/task_depend_over_function.c

@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -verify -fompss-2 -x c++ -ferror-limit 100 -o - %s
+// RUN: %clang_cc1 -verify -fompss-2 -x c -ferror-limit 100 -o - %s
+int *get();
+int main() {
+    #pragma oss task in(get()[3]) // expected-error {{call expressions are not supported}}
+    {}
+}

clang/test/OmpSs/Sema/task_depend_over_lambda.cpp

@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -verify -fompss-2 -x c++ -fexceptions -fcxx-exceptions %s -Wuninitialized
+int main() {
+  auto l = []() -> int * { return nullptr; };
+  #pragma oss task in(l()[30]) // expected-error {{call expressions are not supported}}
+  {}
+}

clang/test/OmpSs/Sema/task_oss_depend.cpp

@@ -34,7 +34,7 @@ int main(int argc, char **argv, char *env[]) {
   #pragma oss task in(argv[1][1] = '2')
   #pragma oss task in (vec[1]) // expected-error {{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss task in (argv[0])
-  #pragma oss task in (main)
+  #pragma oss task in (main) // expected-error {{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss task in (a[0]) // expected-error{{expected addressable lvalue expression, array element, array shape or array section}}
   #pragma oss task in (argv[ // expected-error {{expected expression}} expected-error {{expected ']'}} expected-error {{expected ')'}} expected-note {{to match this '['}} expected-note {{to match this '('}}
   #pragma oss task in (argv[: // expected-error {{expected expression}} expected-error {{expected ']'}} expected-error {{expected ')'}} expected-note {{to match this '['}} expected-note {{to match this '('}}