Send post_save signal with all the parameters required by its annotation #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, I have the same issue and I hope this would be merge asap, badly needed this fix. thanks! |
|
Thanks for reminding me. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great app!
Some time ago there was a pull request that added additional parameters to the pre_save signal, because of compatibility issues with django-cleanup. As it turns out, the lack of parameters for the post_save signal is also breaking some apps (django-reversion in my case). So, following the example of the previous contributor, I added the additional parameters to the post_save method as well.
Please, see if my changes can be merged in, when you have a chance.