Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CATPHANTOM ANALYSIS #503

Open
Rahul-py-linac opened this issue Jul 12, 2024 · 4 comments
Open

CATPHANTOM ANALYSIS #503

Rahul-py-linac opened this issue Jul 12, 2024 · 4 comments

Comments

@Rahul-py-linac
Copy link

CAT PHANTOM CP604 MODLE
The CAT Phantom 604 has contradicting in its model of different sections in the source code.
would kindly update with the new model which would be really use full for analyzing the CAT Phantom.
catphan604
code

@crcrewso
Copy link
Contributor

By contradiction would you like to see that the names of the modules from the manuals instead of the modules as related to the 504 phantom?

@Rahul-py-linac
Copy link
Author

Yes, the CATPHAN604 sections shown above are different from the modules mentioned in the source code.

@crcrewso
Copy link
Contributor

Yes, the CATPHAN604 sections shown above are different from the modules mentioned in the source code.

I agree, the proper names should be used, and alias' added for historical compatibity (technical and human)

@jrkerns
Copy link
Owner

jrkerns commented Jul 23, 2024

Yes, this is a very old convention that was meant so code could be adjusted more easily by only adjusting the initial class constructor. I.e. you could always get to the uniformity section by doing .ctp486, etc. You'd be surprised how many users conflate the 604 with the 504, so being able to just switch the constructor was actually advantageous for that issue. The human-readable naming is easy to change. Yes, creating aliases is definitely the way to go for compatibility. Only downside is having, say, 8 modules in results_data instead of the expected 4 (all RadMachine customers use the output from results_data for reference and tolerance checking). I will put a ticket in our system to see if the PM concurs with that flow. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants