From 7c74935833894231341341d457fff6262052ee4d Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:12:22 +0200 Subject: [PATCH 1/4] fix nyc version for Node.js 8 and 9 on ci pipeline --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 05dd013..9f3f7da 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -77,12 +77,12 @@ jobs: - name: Node.js 8.x node-version: "8.17" - npm-i: mocha@7.2.0 + npm-i: mocha@7.2.0 nyc@14.1.1 npm-rm: beautify-benchmark benchmark - name: Node.js 9.x node-version: "9.11" - npm-i: mocha@7.2.0 + npm-i: mocha@7.2.0 nyc@14.1.1 npm-rm: beautify-benchmark benchmark - name: Node.js 10.x @@ -188,5 +188,5 @@ jobs: - name: Upload code coverage uses: coverallsapp/github-action@master with: - github-token: ${{ secrets.github_token }} + github-token: ${{ secrets.GITHUB_TOKEN }} parallel-finished: true From 78d8115fc1db0dc3319c0127490470598db42bc8 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:21:52 +0200 Subject: [PATCH 2/4] add missing Node.js versions to ci pipeline --- .github/workflows/ci.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9f3f7da..2622035 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,12 @@ jobs: - Node.js 14.x - Node.js 15.x - Node.js 16.x + - Node.js 17.x + - Node.js 18.x + - Node.js 19.x + - Node.js 20.x + - Node.js 21.x + - Node.js 22.x include: - name: Node.js 0.10 @@ -113,6 +119,30 @@ jobs: node-version: "16.2" npm-rm: beautify-benchmark benchmark + - name: Node.js 17.x + node-version: "17.9" + npm-rm: beautify-benchmark benchmark + + - name: Node.js 18.x + node-version: "18.18" + npm-rm: beautify-benchmark benchmark + + - name: Node.js 19.x + node-version: "19.9" + npm-rm: beautify-benchmark benchmark + + - name: Node.js 20.x + node-version: "20.9" + npm-rm: beautify-benchmark benchmark + + - name: Node.js 21.x + node-version: "21.7" + npm-rm: beautify-benchmark benchmark + + - name: Node.js 22.x + node-version: "22.0" + npm-rm: beautify-benchmark benchmark + steps: - uses: actions/checkout@v2 From 61e940711082a6161471ddb6e4856093625a6d27 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:23:16 +0200 Subject: [PATCH 3/4] use action/checkout@4 on ci pipeline --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2622035..1c0d625 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -144,7 +144,7 @@ jobs: npm-rm: beautify-benchmark benchmark steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install Node.js ${{ matrix.node-version }} shell: bash -eo pipefail -l {0} From 5322bce01da614674cd339f6929ab9c6d02bfbb4 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:25:52 +0200 Subject: [PATCH 4/4] fix npm config for new Node.js versions on ci pipeline --- .github/workflows/ci.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1c0d625..d048bd2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -156,7 +156,12 @@ jobs: dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH" - name: Configure npm - run: npm config set shrinkwrap false + run: | + if [[ "$(npm config get package-lock)" == "true" ]]; then + npm config set package-lock false + else + npm config set shrinkwrap false + fi - name: Remove npm module(s) ${{ matrix.npm-rm }} run: npm rm --silent --save-dev ${{ matrix.npm-rm }}