Fix and upgrade ci pipeline #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
May 1, 2024
|
@UlisesGascon @wesleytodd I am struggling to get the CI pipeline run on Node.js 0.6 Have you experienced this error before? Snapshot came from this run https://github.com/carpasse/range-parser/actions/runs/8936686852/job/24547511633 |
carpasse
force-pushed
the
fix-and-upgrad-ci-pipeline
branch
2 times, most recently
from
8f0e5c5
to
f4f9705
Compare
|
I have not seen it but to me this just looks like a great opportunity to ignore it because spending any time on supporting tests in 0.6 is a waste of effort 🤣. I personally am comfortable dropping this test target but saying: we are pretty sure it is not broken, just CI is broken. We will be dropping support and STRONGLY suggest folks not run unsupported node versions" |
|
Agree, I will amend the PR |
Test are most likely not broken but running the tests on such and old version is no longer feasible.
carpasse
force-pushed
the
fix-and-upgrad-ci-pipeline
branch
from
f4f9705
to
979efa7
Compare
UlisesGascon
approved these changes
May 5, 2024
wesleytodd
approved these changes
May 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.