From c94612087a26bfb056de6be802d5d60d42a84a1a Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:33:59 +0200 Subject: [PATCH 1/5] fix mocha and nyc on ci pipeline --- .github/workflows/ci.yml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ed670c3..96acd43 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,24 +68,31 @@ jobs: - name: Node.js 6.x node-version: "6.17" + npm-i: mocha@6.2.2 nyc@14.1.1 - name: Node.js 7.x node-version: "7.10" + npm-i: mocha@6.2.2 nyc@14.1.1 - name: Node.js 8.x - node-version: "8.16" + node-version: "8.17" + npm-i: mocha@7.1.2 nyc@14.1.1 - name: Node.js 9.x node-version: "9.11" + npm-i: mocha@7.1.2 nyc@14.1.1 - name: Node.js 10.x - node-version: "10.15" + node-version: "10.24" + npm-i: mocha@8.4.0 - name: Node.js 11.x node-version: "11.15" + npm-i: mocha@8.4.0 - name: Node.js 12.x - node-version: "12.2" + node-version: "12.22" + npm-i: mocha@9.2.2 steps: - uses: actions/checkout@v2 From bcf83e9760811f27a08fedbec5b66ac472780326 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:36:29 +0200 Subject: [PATCH 2/5] add missing Node.js versions to ci pipeline --- .github/workflows/ci.yml | 48 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 96acd43..616a238 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,6 +26,16 @@ jobs: - Node.js 10.x - Node.js 11.x - Node.js 12.x + - Node.js 13.x + - Node.js 14.x + - Node.js 15.x + - Node.js 16.x + - Node.js 17.x + - Node.js 18.x + - Node.js 19.x + - Node.js 20.x + - Node.js 21.x + - Node.js 22.x include: - name: Node.js 0.6 @@ -94,6 +104,37 @@ jobs: node-version: "12.22" npm-i: mocha@9.2.2 + - name: Node.js 13.x + node-version: "13.14" + npm-i: mocha@9.2.2 + + - name: Node.js 14.x + node-version: "14.21" + + - name: Node.js 15.x + node-version: "15.14" + + - name: Node.js 16.x + node-version: "16.20" + + - name: Node.js 17.x + node-version: "17.9" + + - name: Node.js 18.x + node-version: "18.18" + + - name: Node.js 19.x + node-version: "19.9" + + - name: Node.js 20.x + node-version: "20.9" + + - name: Node.js 21.x + node-version: "21.7" + + - name: Node.js 22.x + node-version: "22.0" + steps: - uses: actions/checkout@v2 @@ -120,7 +161,12 @@ jobs: dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH" - name: Configure npm - run: npm config set shrinkwrap false + run: | + if [[ "$(npm config get package-lock)" == "true" ]]; then + npm config set package-lock false + else + npm config set shrinkwrap false + fi - name: Remove npm module(s) ${{ matrix.npm-rm }} run: npm rm --silent --save-dev ${{ matrix.npm-rm }} From b8311a7afbfb7f762e0a1d48601c560951d9a994 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Wed, 1 May 2024 08:37:20 +0200 Subject: [PATCH 3/5] use action/checkout@v4 on ci pipeline --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 616a238..01a6fae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -136,7 +136,7 @@ jobs: node-version: "22.0" steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install Node.js ${{ matrix.node-version }} shell: bash -eo pipefail -l {0} From b4929d0b7ab2c13430508e8ec45d100667ce8198 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Fri, 3 May 2024 11:02:03 +0200 Subject: [PATCH 4/5] run tests on ubuntu latest. Seems that GH doesn't have runners for ubuntu 18 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 01a6fae..cef2e35 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,7 +6,7 @@ on: jobs: test: - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest strategy: matrix: name: From 979efa718d98b4eea319996b1d01e4e3e6087c66 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Sat, 4 May 2024 07:44:47 +0200 Subject: [PATCH 5/5] drop Node.js 0.6 from CI pipeline. Test are most likely not broken but running the tests on such and old version is no longer feasible. --- .github/workflows/ci.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cef2e35..9da0a2c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,6 @@ jobs: strategy: matrix: name: - - Node.js 0.6 - Node.js 0.8 - Node.js 0.10 - Node.js 0.12 @@ -38,10 +37,6 @@ jobs: - Node.js 22.x include: - - name: Node.js 0.6 - node-version: "0.6" - npm-i: mocha@1.21.5 - npm-rm: nyc - name: Node.js 0.8 node-version: "0.8" @@ -141,11 +136,6 @@ jobs: - name: Install Node.js ${{ matrix.node-version }} shell: bash -eo pipefail -l {0} run: | - if [[ "${{ matrix.node-version }}" == 0.6* ]]; then - sudo apt-get install g++-4.8 gcc-4.8 libssl1.0-dev - export CC=/usr/bin/gcc-4.8 - export CXX=/usr/bin/g++-4.8 - fi nvm install --default ${{ matrix.node-version }} if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then nvm install --alias=npm 0.10