Skip to content

New release? #298

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
FlorianSW opened this issue Aug 12, 2016 · 7 comments
Closed

New release? #298

FlorianSW opened this issue Aug 12, 2016 · 7 comments

Comments

@FlorianSW
Copy link
Contributor

FlorianSW commented Aug 12, 2016

Since the last release in June, the library had some commits (some of them could be inportant for users of the library). Is there any plan for the next release? When it comes, what it contains and what version number it'll have? :)

Best,
Florian

@bighappyface
Copy link
Collaborator

I'm ready to bump to 3.0.0 and am really just dithering on whether to include #277. If not then that PR will probably warrant another major bump to 4.0.0.

I'm open to suggestions.

@FlorianSW
Copy link
Contributor Author

PR #277 looks like a really big change :/ However, having to major versions in a reasonable short time isn't really consumer friendly, too. So I (personally) would prefer to have the major change in the upcoming 3.0.0 major release.

However, I haven't reviewed the code so far (sorry), and it seems, that I don't plan to do so (sorry again :(). From a first glance it looks reasonable and should work. So, if you've tested it and it works like expected (with the new example code in the README), count this as a "community-support", at least from me :P

@bighappyface
Copy link
Collaborator

Unfortunately many PRs come in that, well, completely overhaul things and those contributors are rarely concerned with a) the implications and b) helping ensure a smooth review/acceptance. They just put it on the maintainer and expect things to be merged, which really makes being a maintainer a thankless job (to say the least). Consumer friendliness isn't a hallmark of software development.

@bighappyface
Copy link
Collaborator

https://github.com/justinrainbow/json-schema/releases/tag/3.0.0

@steffkes
Copy link
Contributor

i'm one of the guys bringing in a crazy PR and not having as much time as i'd like to review the work others did and help you out @bighappyface :/

I'll try to get a bit of time this week to review #277 and hopefully a few more - shouldn't be that hard. saying i don't actually need it feels a bit to easy for my taste .. if everyone would go with that, i don't think this library would be where it is right now.

@steffkes
Copy link
Contributor

okay, that went down fast *g nevertheless, i'm trying to scrape out a few minutes/hours every now and then and trying to help out reviewing PRs and issues. we'll see how good i am at this ;o

@bighappyface
Copy link
Collaborator

@steffkes I know how you feel :D

Thanks a ton for your help, no matter how big or small.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants