-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Unknown expression type ThisExpression
#41
Comments
Yeah, it should be more fault tolerant than that 😦 Mind sharing the JSX that was used so I can add a handler for a |
I have no idea - I ran it on our huge codebase and it doesn't tell me which file it's looking at :-/ |
Ah, that's okay, I've created a function to handle |
I'd say it'd be better for it to fail with a meaningful error message. |
as in an actual |
sure, perhaps with the filename and line number |
@evcohen not to put too much pressure on you, but this is blocking release of v8 of eslint-config-airbnb ;-) is it something you hope to get out soon? |
ah working on it now, sorry about that. will let you know when im about to publish. |
actually, let me just get a fix out for |
Just published v1.0.2 let me know if you face any other issues. I'm going to work on better error handling right now for every rule. |
Thanks! |
@evcohen I just got this error with version 1.0.3 for the rule In our code base I found this:
Removing the |
thanks @ivarni will get you a fix for that right now and work on error handling today. |
Fixed |
I'm still seeing this error with v1.0.4, the line of source that's triggering it is:
And sure enough, Changing that line to use a template literal "fixes" the problem:
|
on v1.0.1:
I added a
console.log
to line 101 in index.js and got:Perhaps the comment
"This will map correctly for *all* possible expression types."
above the function is inaccurate, and it should be explicitly handling unknown expression types?The text was updated successfully, but these errors were encountered: