Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

I think this all needs to be wrapped in a @static if VERSION < v"1.6" ... else ret = INSTANCE(ps) end to match old parsing behaviour. Not clear if v1.6 is the correct cut off. #292

Closed
davidanthoff opened this issue Jul 23, 2021 · 0 comments · Fixed by #295
Closed

I think this all needs to be wrapped in a @static if VERSION < v"1.6" ... else ret = INSTANCE(ps) end to match old parsing behaviour. Not clear if v1.6 is the correct cut off. #292

davidanthoff opened this issue Jul 23, 2021 · 0 comments · Fixed by #295
Assignees
@ZacLN @pfitzseb
Labels
bug
Milestone
Next Bugfix Release

Comments

@davidanthoff
Copy link
Member

I think this all needs to be wrapped in a @static if VERSION < v"1.6" ... else ret = INSTANCE(ps) end to match old parsing behaviour. Not clear if v1.6 is the correct cut off.

Originally posted by @ZacLN in #291 (comment)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ZacLN ZacLN

@pfitzseb pfitzseb

Labels
bug
Projects
None yet
Milestone
Next Bugfix Release
Development

Successfully merging a pull request may close this issue.

fix legacy parsing of dotops julia-vscode/CSTParser.jl
3 participants
@davidanthoff @ZacLN @pfitzseb