Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Track the number of semicolons in multidimensional expressions #323

Closed
domluna opened this issue Jan 8, 2022 · 1 comment
Closed

Track the number of semicolons in multidimensional expressions #323

domluna opened this issue Jan 8, 2022 · 1 comment

Comments

@domluna
Copy link

domluna commented Jan 8, 2022

ref domluna/JuliaFormatter.jl#532

The current way this is being done in JuliaFormatter is kind of hacky and could be greatly simplified if this is stored in the meta or trivia fields. Is this a viable approach?

@pfitzseb
Copy link
Member

Semicolons aren't explicitly tracked on master, but ncat/nrow expressions now include their dimensionality. That should almost always be enough info, except for

[1 2;;
 3 4]

I think. It's of course always valid to rewrite that to [1 2 3 4], so I'm not sure if you strictly need that info.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants