Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: correctly iterate over :publics #394

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

pfitzseb
Copy link
Member

No description provided.

davidanthoff
davidanthoff previously approved these changes Jul 13, 2024
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But tests fail, so probably still needs some work?

@pfitzseb
Copy link
Member Author

Yeah, forgot to disable the test on older Julia versions... Should hopefully run fine now.

@pfitzseb pfitzseb merged commit 44f622f into master Jul 14, 2024
55 of 57 checks passed
@davidanthoff davidanthoff deleted the sp/fix-public-iterate branch July 14, 2024 16:46
@davidanthoff
Copy link
Member

I should implement the skip keyword on @testitems :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants