Add test for errors on wrongly requested methods

Author: Seelengrab

test/test_typed.jl

@@ -1,27 +1,32 @@
-@testset "Message dispatcher" begin
-
+function socket_path(id)
     if Sys.iswindows()
-        global_socket_name1 = "\\\\.\\pipe\\jsonrpc-testrun1"
+        return "\\\\.\\pipe\\jsonrpc-testrun$id"
     elseif Sys.isunix()
-        global_socket_name1 = joinpath(tempdir(), "jsonrpc-testrun1")
+        return joinpath(mktempdir(), "jsonrpc-testrun$id")
     else
         error("Unknown operating system.")
     end
+end
+
+@testset "Message dispatcher" begin
+
+    global_socket_name1 = socket_path(1)
 
     request1_type = JSONRPC.RequestType("request1", Foo, String)
     request2_type = JSONRPC.RequestType("request2", Nothing, String)
     notify1_type = JSONRPC.NotificationType("notify1", String)
 
     global g_var = ""
 
-    server_is_up = Base.Condition()
+    server_is_up1 = Base.Condition()
 
     server_task = @async try
         server = listen(global_socket_name1)
-        notify(server_is_up)
+        notify(server_is_up1)
+        yield() # don't want to deadlock
         sock = accept(server)
         global conn = JSONRPC.JSONRPCEndpoint(sock, sock)
-        global msg_dispatcher = JSONRPC.MsgDispatcher()
+        msg_dispatcher = JSONRPC.MsgDispatcher()
 
         msg_dispatcher[request1_type] = (conn, params) -> begin
             @test JSONRPC.is_currently_handling_msg(msg_dispatcher)
@@ -39,7 +44,7 @@
         Base.display_error(stderr, err, catch_backtrace())
     end
 
-    wait(server_is_up)
+    wait(server_is_up1)
 
     sock2 = connect(global_socket_name1)
     conn2 = JSONRPCEndpoint(sock2, sock2)
@@ -63,22 +68,17 @@
 
     # Now we test a faulty server
 
-    if Sys.iswindows()
-        global_socket_name2 = "\\\\.\\pipe\\jsonrpc-testrun2"
-    elseif Sys.isunix()
-        global_socket_name2 = joinpath(tempdir(), "jsonrpc-testrun2")
-    else
-        error("Unknown operating system.")
-    end
+    global_socket_name2 = socket_path(2)
 
-    server_is_up = Base.Condition()
+    server_is_up2 = Base.Condition()
 
     server_task2 = @async try
         server = listen(global_socket_name2)
-        notify(server_is_up)
+        notify(server_is_up2)
+        yield() # don't want to deadlock
         sock = accept(server)
         global conn = JSONRPC.JSONRPCEndpoint(sock, sock)
-        global msg_dispatcher = JSONRPC.MsgDispatcher()
+        msg_dispatcher = JSONRPC.MsgDispatcher()
 
         msg_dispatcher[request2_type] = (conn, params)->34 # The request type requires a `String` return, so this tests whether we get an error.
 
@@ -91,7 +91,7 @@
         Base.display_error(stderr, err, catch_backtrace())
     end
 
-    wait(server_is_up)
+    wait(server_is_up2)
 
     sock2 = connect(global_socket_name2)
     conn2 = JSONRPCEndpoint(sock2, sock2)
@@ -104,6 +104,45 @@
     close(sock2)
     close(conn)
 
-    fetch(server_task)
+    fetch(server_task2)
+
+
+    # Now we test a wrongly requested method
+
+    global_socket_name3 = socket_path(3)
+
+    server_is_up3 = Base.Condition()
+
+    server_task3 = @async try
+        server = listen(global_socket_name3)
+        notify(server_is_up3)
+        yield() # don't want to deadlock
+        sock = accept(server)
+        global conn = JSONRPC.JSONRPCEndpoint(sock, sock)
+        msg_dispatcher = JSONRPC.MsgDispatcher()
+
+        run(conn)
+
+        for msg in conn
+            @test_throws ErrorException("Unknown method 'request2'.") JSONRPC.dispatch_msg(conn, msg_dispatcher, msg)
+            flush(conn)
+        end
+    catch err
+        Base.display_error(stderr, err, catch_backtrace())
+    end
+
+    wait(server_is_up3)
+
+    sock3 = connect(global_socket_name3)
+    conn3 = JSONRPCEndpoint(sock3, sock3)
+
+    run(conn3)
+
+    @test_throws JSONRPC.JSONRPCError(-32601, "Unknown method 'request2'.", nothing) JSONRPC.send(conn3, request2_type, nothing)
+
+    close(conn3)
+    close(sock3)
+    close(conn)
+    fetch(server_task3)
 
 end