Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TestItemRunner should skip child directories that have their own Project.toml that define a package #41

Open
NHDaly opened this issue Jan 19, 2023 · 0 comments

Comments

@NHDaly
Copy link

NHDaly commented Jan 19, 2023

VSCode test running follows this simple rule: for each @testitem we look in the folder, then in the parent folder etc until we find a Project.toml that defines a package, and then the @testitem is part of that package.

The TestItemRunner.jl implementation doesn't follow that philosophy fully, I think what is missing there is that we should by default skip any child folder that has a new Project.toml in it that defines a new package. So in @NHDaly's tree, if someone runs test/runtests.jl, then that should actually not run the @testitems of the sub packages, right?

Originally posted by @davidanthoff in #39 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant