Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Request: ARM Support #4

Open
espenaf opened this issue Oct 13, 2021 · 5 comments
Open

Feature Request: ARM Support #4

espenaf opened this issue Oct 13, 2021 · 5 comments

Comments

@espenaf
Copy link

espenaf commented Oct 13, 2021

Hi there

ARM support would be awesome

@julian7
Copy link
Owner

julian7 commented Feb 14, 2022

I can't test it myself. Do you think a simple cross-compilation would suffice?

@espenaf
Copy link
Author

espenaf commented Feb 15, 2022

If you look at https://github.com/sensu/check-disk-usage or https://github.com/sensu/check-cpu-usage, these plugins have been setup with a way to publish arm5/6/7/64 based artifacts for the asset. Doing something similar will maybe work, and then I can test the new ARM built versions.

@julian7
Copy link
Owner

julian7 commented Feb 22, 2022

I've released v0.5.0 with ARM v7 and ARM64 support. Could you please have a look?

@espenaf
Copy link
Author

espenaf commented Feb 22, 2022

The binaries worked just fine, tested on a cluster of 4 Raspberry Pi`s (3 and 4).

There is one small remaining issue with how the asset definition is being created, this was fixed in the check template in sensu/check-plugin-template#11:

Asset filters for ARM entities need to use entity.system.arch == 'arm' and entity.system.arm_version == X instead of entity.system.arch == 'armX'.

@julian7
Copy link
Owner

julian7 commented Feb 24, 2022

Hmm the beauty of undoc features. While examples are full with arm_version mentions, it's not mentioned in system attributes.
Its definition is in core system type.

I have to take it back, as the asset yaml configuration is in GoShipDone's sensulib extension, but I hope I'll have some time during the weekend to implement this change.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants