From 61d2a2782a694068542f2e6476c6e0b0b407e80d Mon Sep 17 00:00:00 2001 From: Junyuan Chen Date: Sun, 31 Mar 2024 21:48:54 -0700 Subject: [PATCH] Remove the unnessary method --- src/LabeledArrays.jl | 6 ------ test/LabeledArrays.jl | 3 +++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/LabeledArrays.jl b/src/LabeledArrays.jl index 12277c1..632cfb1 100644 --- a/src/LabeledArrays.jl +++ b/src/LabeledArrays.jl @@ -365,12 +365,6 @@ Base.@propagate_inbounds function Base.getindex(x::LabeledArrOrSubOrReshape{V,K, return LabeledValue{V,K}(val, getvaluelabels(x)) end -Base.@propagate_inbounds function Base.getindex(x::LabeledArrOrSubOrReshape{V,N}, - I::Vararg{Any,N}) where {V,N} - val = refarray(x)[I...] - return LabeledArray(val, getvaluelabels(x)) -end - Base.fill!(x::LabeledArrOrSubOrReshape, v) = (fill!(refarray(x), unwrap(v)); x) Base.resize!(x::LabeledVector, n::Integer) = (resize!(refarray(x), n); x) diff --git a/test/LabeledArrays.jl b/test/LabeledArrays.jl index 34b740b..e2aa39d 100644 --- a/test/LabeledArrays.jl +++ b/test/LabeledArrays.jl @@ -127,6 +127,9 @@ end v = reshape(x, 3, 2)[1:2] @test v isa LabeledArray @test v.labels === lbls + v = reshape(x, 3, 2)[1:2, 1:2] + @test v isa LabeledArray + @test v.labels === lbls v = view(x2, 1:3)[1:2] @test v isa LabeledArray @test v.labels === lbls