Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JQueryMX breaks when JQuery is in no-conflicts mode #134

Open
etremel opened this issue Aug 2, 2012 · 1 comment
Open

JQueryMX breaks when JQuery is in no-conflicts mode #134

etremel opened this issue Aug 2, 2012 · 1 comment

Comments

@etremel
Copy link

etremel commented Aug 2, 2012

JQueryMX, at least the View component, breaks when the local JQuery installation is set to no-conflicts mode because it uses the global window.$ variable to refer to jQuery -- when loading a view, JavaScript throws a "$ is undefined" error.

A cursory inspection of the view.js code suggests that the problem is a failure to correctly implement the "pass jQuery to a parameter called $" paradigm. There are several blocks of code wrapped in functions like this:

(function() {
    ...
})(jQuery);

which does not actually declare $ as a parameter but attempts to pass jQuery to it anyway. This means that calls to $.View inside these blocks will refer to the global $ variable instead of a local parameter, and will fail if JQuery is in no-conflicts mode.

@justinbmeyer
Copy link
Member

Thanks, seems like our builder is broken.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants